fix(file-nesting): ensure deterministic rule application #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rules (nvim-neo-tree#1494) When multiple file nesting rules were configured, rules were being applied inconsistently. For example, sometimes when both `package.json` and `vite.config.*` rules existed, only one set of rules would be applied while the other would be ignored intermittently. Example configuration that was working inconsistently: ```lua { ['vite.config.*'] = { files = { '%.babelrc*', 'babel%.config%.*', 'postcss%.config%.*', 'tailwind%.config%.*', '%.env%.*', 'tsconfig%.*' }, pattern = 'vite%.config%.(.*)$' }, ['package.json'] = { files = { '%.browserslist*', 'bower%.json', 'package-lock%.json', 'yarn%.lock', '%.eslint*', '%.prettier*' }, pattern = 'package%.json$' } } ``` The fix modifies the nesting logic to: - Collect all matching rules before applying any nesting - Use file IDs to prevent duplicate nesting - Track nested status properly - Apply rules in a deterministic order This ensures that all configured nesting rules are applied consistently regardless of their order or complexity. Fixes nvim-neo-tree#1494
3 tasks
|
It sounds like a good solution, but I'm afraid I don't have the time to properly evaluate it. See #1606. |
pynappo
reviewed
Dec 31, 2024
|
Made the rule application actually deterministic. Rules now have an optional lmk if you could try it out and make sure it works and i'll merge. |
pynappo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple file nesting rules were configured, rules were being applied inconsistently. For example, sometimes when both
package.jsonandvite.config.*rules existed, only one set of rules would be applied while the other would be ignored intermittently.Example configuration that was working inconsistently:
{ nesting_rules = require('neotree-file-nesting-config').nesting_rules, }The fix modifies the nesting logic to:
This ensures that all configured nesting rules are applied consistently regardless of their order or complexity.
Fixes #1494