fix: count unicode codepoints instead of bytes #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyazdani42
requested changes
Jul 20, 2022
lua/nvim-tree/view.lua
Outdated
| local _, count = string.gsub(l, "[^\128-\193]", "") | ||
| count = count + 3 -- add padding | ||
| if max_length < count then | ||
| max_length = count |
There was a problem hiding this comment.
could you use the vim.fn.strchars instead ?
There was a problem hiding this comment.
Wasn't aware this function existed, I just amended my commit.
kyazdani42
approved these changes
Jul 20, 2022
|
thanks for the contribution ! |
Almo7aya
pushed a commit
to Almo7aya/nvim-tree.lua
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
adaptive_size = truethere is some extra padding (usually around 4-6 spaces). This is happening due to the unicode characters such as file or folder icon. For examplestring.len(" .hooks")(equivalent with #string ) will return 14, but this string only needs 10 spaces to be printed.This commit fixes this issue and sets the width of the window to the true
max_length+ 1 space for padding.