Skip to content

fix(#1533): make toggle_mark ignore non-togglable nodes. #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sebcode
Copy link
Contributor

@sebcode sebcode commented Aug 21, 2022

resolves #1533

@alex-courtis
Copy link
Member

Thanks for all these fixes!

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested:
hide_root_folder true/false
first, second, last nodes

@@ -17,6 +17,10 @@ local function remove_mark(node)
end

function M.toggle_mark(node)
if node.absolute_path == nil then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simpler than is_root_folder_visible

@alex-courtis alex-courtis merged commit 90dcf42 into nvim-tree:master Aug 22, 2022
Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toggle_mark on root node throws exception
2 participants