fix(#1270): open_on_setup_file does not override open_on_setup, hijack_directories does not override startup behaviour

[alex-courtis]

Investigating #1270 and found some bugs and inconsistencies:

Bugs: open_on_setup_file overrides open_on_setup

Inconsistencies: hijack_directories overrides open_on_setup. Not necessarily a bug, however this behaviour has been updated to match the documentation.

Documentation has been clarified.

[alex-courtis]

Test cases:

defaults

• file
• dir
• empty
• none

open_on_setup

• file
• dir
• empty
• none

open_on_setup_file

• file
• dir
• empty
• none

open_on_setup, open_on_setup_file

• file
• dir
• empty
• none

open_on_setup, ignore_buffer_on_setup

• file
• dir
• empty
• none

open_on_setup_file, ignore_ft_on_setup

• file ft match
• file
• dir
• empty
  none

open_on_setup, ignore_ft_on_setup

• file ft match
• file
• dir
• empty
• none

[alex-courtis]

If we were building from scratch today, I'd define options like these, however that is way too disruptive a change to make:

  startup = {
    open = {
      always = false,
      dir = false,
      file = false,
      empty = false,
    },
    focus_tree = {
      always = false,
      dir = false,
      file = false,
      empty = false,
    },
    ignore_ft = {
    }
  }

[kyazdani42]

i have edge case testing for open on setup also:

• man man with export MANPAGER="nvim +Man!" or git operations with nvim.
• lazy loading, but this shouldn't be affected.

[alex-courtis]

• man man with export MANPAGER="nvim +Man!"

This doesn't open the tree unless:

    ignore_buffer_on_setup = true,
    open_on_setup = true,

git operations with nvim

The tree will be opened when open_on_setup_file = true. I've never actually noticed this, but now you point it out I do...

This can be stopped via:

		ignore_ft_on_setup = {
			"gitcommit"
		},

Perhaps we could add that as a default.

I think I'm missing something...

[kyazdani42]

thats good then, the behavior might be the same as before.

[kyazdani42]

lets try this, if users complain we can just revert.

[alex-courtis]

Unfortunately this change has been reverted due to many regressions: #1668

A new mechanism to control startup behaviour is under way: #1669