Skip to content

[WIP] allow passing a custom function as a window picker #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 16, 2022
Merged

[WIP] allow passing a custom function as a window picker #1782

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ef2ef2e
feat: allow passing a custom function as a window picker
davidsierradz Nov 28, 2022
c984b76
fix: move logic expression to if statement
davidsierradz Nov 29, 2022
01b63e4
feat(open): add window_picker.picker
alex-courtis Dec 3, 2022
a65f293
feat(open): add window_picker.picker
alex-courtis Dec 3, 2022
d7e5731
style nit
alex-courtis Dec 3, 2022
9fbe180
feat(open): add window_picker.picker
davidsierradz Nov 28, 2022
0770c9a
docs: add window_picker.picker documentation
davidsierradz Dec 15, 2022
6245e6d
Merge branch 'feat/custom-window-picker' of github.com:davidsierradz/…
alex-courtis Dec 16, 2022
87797a3
docs: add window_picker.picker documentation
alex-courtis Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lua/nvim-tree.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,7 @@ local DEFAULT_OPTS = { -- BEGIN_DEFAULT_OPTS
resize_window = true,
window_picker = {
enable = true,
picker = "default",
chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890",
exclude = {
filetype = { "notify", "packer", "qf", "diff", "fugitive", "fugitiveblame" },
Expand Down Expand Up @@ -680,6 +681,7 @@ local FIELD_OVERRIDE_TYPECHECK = {
on_attach = { ["function"] = true, string = true },
sort_by = { ["function"] = true, string = true },
root_folder_label = { ["function"] = true, string = true },
picker = { ["function"] = true, string = true },
}

local function validate_options(conf)
Expand Down
6 changes: 5 additions & 1 deletion lua/nvim-tree/actions/node/open-file.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,11 @@ local function get_target_winid(mode, win_ids)
end
else
-- pick a window
target_winid = pick_win_id()
if type(M.window_picker.picker) == "function" then
target_winid = M.window_picker.picker()
else
target_winid = pick_win_id()
end
if target_winid == nil then
-- pick failed/cancelled
return
Expand Down