-
-
Notifications
You must be signed in to change notification settings - Fork 628
feat(commands): add descriptions #2083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of those descriptions just repeat what the command itself already says. This doesn't add any value really. But frankly I have no idea what else it could say. :)
Descriptions look good. Is there any way you can expose the commands as raw data that we can access directly? Sorta like this: https://github.com/mrjones2014/op.nvim/blob/master/lua/op/commands.lua |
Co-authored-by: gegoune <[email protected]>
That's a great idea. Might be a good opportunity to extract the commands to their own file. |
@mrjones2014 I would be most grateful if you tested the new |
Would we ever have any more endpoints for commands? If there is a slightest change maybe it warrants nesting like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as the table structure remains consistent, looks good to me 👍
Much better. Everything is nested now. |
fixes #2076
I would be most grateful for your review @mrjones2014
I've used the
"nvim-tree: "
prefix as per the mappings and kept it brief. Most grateful for suggestions...