fix: api.node.open.preview should toggle directories
#2099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression introduced by 7495975.
gegoune
commented
Mar 29, 2023
| if node.nodes or node.name == ".." then | ||
| return | ||
| if node.name == ".." then | ||
| require("nvim-tree.actions.root.change-dir").fn ".." |
There was a problem hiding this comment.
Might want to return early here. This was inline with previous behaviour.
Suggested change
| require("nvim-tree.actions.root.change-dir").fn ".." | |
| return |
There was a problem hiding this comment.
Testing with 9c97e64 (before on_attach): preview does nothing on the root directory.
However, the change-dir does make sense and brings it in line with open.
How about this help:
api.node.open.edit() *nvim-tree.api.node.open.edit()*
File: open as per |nvim-tree.actions.open_file|
Folder: expand or collapse
Root: change directory up
api.node.open.preview() *nvim-tree.api.node.open.preview()*
Perform |nvim-tree.api.node.edit()|
File buffer will have |bufhidden| set to `delete`.
alex-courtis
approved these changes
Apr 3, 2023
| if node.nodes or node.name == ".." then | ||
| return | ||
| if node.name == ".." then | ||
| require("nvim-tree.actions.root.change-dir").fn ".." |
There was a problem hiding this comment.
Testing with 9c97e64 (before on_attach): preview does nothing on the root directory.
However, the change-dir does make sense and brings it in line with open.
How about this help:
api.node.open.edit() *nvim-tree.api.node.open.edit()*
File: open as per |nvim-tree.actions.open_file|
Folder: expand or collapse
Root: change directory up
api.node.open.preview() *nvim-tree.api.node.open.preview()*
Perform |nvim-tree.api.node.edit()|
File buffer will have |bufhidden| set to `delete`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced by 7495975.
Closes #2097
@alex-courtis I have kept parity with
open_or_expand_or_dir_upin regards to behaviour on.., which might not be desired. I believe we might not want to do anything in that case as it was previously?If we do want to keep parity perhaps those two functions can be merged into one with
previewargument.