fix(#2382): git watcher handles worktrees and submodules, via --absolute-git-dir when it is available #2389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
changed the title
|
#2390 supercedes |
|
#2390 failed. Use this pragmatic but messy solution. |
|
Tidied naming, documented and added more safety. Dogfooding for ~1 week. More refactoring might follow. |
|
Later refactor:
|
alex-courtis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2382
This is clunky: using yet another map for project roots is fragile and not easily maintainable.
Possible refactor: make
get_project_rootprivate, migrating toget_projector similar. Trim down init to do nothing but create the entire project and watchers.