fix(#2392): bookmarks vertical alignment when group_empty

[tjex]

When group_empty is enabled, marks were misaligned if one or more parent nodes were empty. See #2392

Followed the code logic as proposed here

I'm not super confident I've taken all that needs to be into account. It seems to work (see screenshots), but it got fixed quite fast, which doesn't make me confident. Please review with that in mind!..

group_empty enabled:

group_empty disabled (showing that marks are still aligned):

I used the below tree structure (start is just a start script I made):

Below was the minimal config I was using:

vim.g.loaded_netrw = 1
vim.g.loaded_netrwPlugin = 1

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvt-min/site]]
local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
    require("packer").startup {
        {
            "wbthomason/packer.nvim",
            "~/tjroot/dev/neovim/nvim-tree.lua",
            "nvim-tree/nvim-web-devicons",
            -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
        },
        config = {
            package_root = package_root,
            compile_path = install_path .. "/plugin/packer_compiled.lua",
            display = { non_interactive = true },
        },
    }
end
if vim.fn.isdirectory(install_path) == 0 then
    print "Installing nvim-tree and dependencies."
    vim.fn.system { "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path }
end
load_plugins()
require("packer").sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]]
vim.opt.termguicolors = true
vim.opt.cursorline = true

_G.setup = function()
    require("nvim-tree").setup {
        renderer = {
            group_empty = true
        },
    }
end

[alex-courtis]

I'm not super confident I've taken all that needs to be into account.

I've added some logging and shown that the bookmarked nodes were the correct ones. It seems to be just a rendering issue which you have addressed.

[alex-courtis]

Many thanks for your contribution.

Test cases:

• hide_root_folder
• nodes not under group
• nodes under group
• mark group itself - marks the lowest directory node