Skip to content

ci: triggers, nvim stable version & env vars #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2024
Merged

ci: triggers, nvim stable version & env vars #2671

merged 3 commits into from
Feb 12, 2024

Conversation

gegoune
Copy link
Collaborator

@gegoune gegoune commented Feb 11, 2024

This PR updates CI workflow such that

  • push is no longer triggering runs (we don't need to run it on master as it's guarded on PR level, release-please branch should also be triggered by pull_request)
  • nvim version is no longer hardcoded but stable tag is used instead
  • nightly is added to nvim versions matrix - this might prepare us for upcoming releases
  • environment variables are set vie env key instead of inlining them

This PR updates CI workflow such that
- `push` is no longer triggering runs (we don't need to run it on
  master as it's guarded on PR level, release-please branch should
  also be triggered by `pull_request`)
- nvim version is no longer hardcoded but `stable` tag is used instead
- `nightly` is added to nvim versions matrix - this might prepare us
  for upcoming releases
- environment variables are set vie `env` key instead of inlining them
@gegoune gegoune requested a review from alex-courtis February 11, 2024 12:03
@alex-courtis
Copy link
Member

  • push is no longer triggering runs (we don't need to run it on master as it's guarded on PR level, release-please branch should also be triggered by pull_request)

Thank you... I made a real mess of that.

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely works - many thanks!

Nightly should be interesting; as we get more and more of vim into luals we will get very early warnings of any API breakages. There was one between 0.8 and 0.9 with highlighting.

@gegoune gegoune merged commit 863cf83 into master Feb 12, 2024
@gegoune gegoune deleted the ci/workflow branch February 12, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants