fix(view): Don't create a new empty buffer on every open.

[sindrets]

Fixes #301.

Calling vnew creates a new empty buffer every time the tree opens. The window then changes to the correct buffer only a couple lines later, leaving the unused, unneeded, empty buffer behind.

[Shatur]

After this PR I have an error:

E5108: Error executing lua ...im/pack/plugins/opt/nvim-tree.lua/lua/nvim-tree/view.lua:142: Vim(buffer):E86: Buffer 2 does not exist

Steps to reproduce:

:NvimTreeToggle
:setlocal bufhidden=wipe
:bd
:NvimTreeToggle

[sindrets]

@Shatur95 Not related to this PR. That happened before this change. But I have created a draft for a new PR that would solve your described problem #307.

But why do you want to set bufhidden=wipe on the tree buffer?

[kyazdani42]

do not set wipe, I do not recreate the buffer two time

[Shatur]

Not related to this PR. That happened before this change.

Sorry, I was wrong with the commit number :(
And thanks for the fix!

But why do you want to set bufhidden=wipe on the tree buffer?
do not set wipe, I do not recreate the buffer two time

I just have a custom function that closes the buffers. Should I add nvim-tree to exceptions or should I not use bufhidden = wipe for other buffers too?

[kyazdani42]

depends the use case, but it would be better to make nvim-tree an exception because you don't want to reload the whole buffer each time when it doesn't change and doesn't consume too much ram :)

[Shatur]

depends the use case, but it would be better to make nvim-tree an exception because you don't want to reload the whole buffer each time when it doesn't change and doesn't consume too much ram :)

Thanks for the tip, will do!

[LoydAndrew]

I have the same error if I close tree with :bd or q. But I don't have buffhiden set to anything, :set buffhiden? shows buffhiden=
What do I missing? Sorry to I ask here, but this thread is kind of related.

[kyazdani42]

after some time, i agree that trying to keep the tree bufnr always the same was quite a bad idea. I didn't think about users enough 😄 Maybe try to not :bd the tree then, NvimTreeClose handles that by itself already

[LoydAndrew]

Yeah, that's the thing. It doesn't work with NvimTreeClose either (and I guess pressing :q on NvimTree buffer is equivalent to NvimTreeClose).