chore: use builtin EmmyLuaCodeStyle for style checking #3084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
force-pushed
the
chore-sync-EmmyLuaCodeStyle
branch
from
9a6a195 to
3a27e36
Compare
alex-courtis
changed the title
This reverts commit e5fde80.
alex-courtis
commented
Mar 22, 2025
| @@ -1,12 +1,23 @@ | |||
| { | |||
| "$schema": "https://raw.githubusercontent.com/sumneko/vscode-lua/master/setting/schema.json", | |||
| "runtime.version.luals-check-only": "Lua 5.1", | |||
There was a problem hiding this comment.
Uses a better jq solution in script.
alex-courtis
commented
Mar 22, 2025
| local stat = vim.loop.fs_lstat(abs) | ||
| -- path incorrectly specified as an integer | ||
| local stat = vim.loop.fs_lstat(abs) ---@diagnostic disable-line param-type-mismatch | ||
|
|
There was a problem hiding this comment.
result of lua-language-server upgrade
alex-courtis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update versions:
Small ci.yml tweaks.
Use the embedded EmmyLuaCodeStyle
CodeFormatwhen checking style. This makes it easier for those who don't have it installed, as well as simlifying CI.CodeFormatbinary is still required for fixing style; doc updated.Contentious change: style job collapsed into check, as they have all prerequisites in common.
TODO: update required checks following merge