feat: add option to hide root dir path #631

jim-fx · 2021-09-23T22:36:14Z

This pull request adds a configuration option: let g:nvim_tree_hide_root_folder, which when enabled hides the path of the root folder on top of the tree like so:

let g:nvim_tree_hide_root_folder = 0; --default

let g:nvim_tree_hide_root_folder = 1;

The intention is to allow for a more minimalistic ui, and for me personally tmux already shows the current directory so this information is sort of redundant.

Thanks for the aaaawsome plugin and cheers,

Jim

kyazdani42

looks like your PR breaks indentations quite a lot, it will not pass linting. I'm going to merge the setup refactoring, you should then rebase because options like this should not be global anymore :) But it's indeed a wanted change, i believe users have asked for this some time ago.

kunish · 2021-09-27T03:16:58Z

Really nice feature! Looking forward to it.

* chore: refacto setup part 1 refacto setup for code entrypoint following options switched boolean values as options to the setup function: - `nvim_tree_disable_netrw` -> `disable_netrw` - `nvim_tree_hijack_netrw` -> `hijack_netrw` - `nvim_tree_auto_open` -> `open_on_setup` - `nvim_tree_auto_close` -> `auto_close` - `nvim_tree_tab_open` -> `tab_open` - `nvim-tree-update-cwd` -> `update_cwd` - `nvim_tree_hijack_cursor` -> `hijack_cursor` - `nvim_tree_system_open_command` -> `system_open.cmd` - `nvim_tree_system_open_command_args` -> `system_open.args` - `nvim_tree_follow` -> `update_focused_file.enable` - `nvim_tree_follow_update_path` -> `update_focused_file.update_cwd` Also added new option `update_focused_file.ignore_list` which will ignore filepath or filetypes that matches one entry of the list when updating the path if update_cwd is true. * add deprecation warning * update readme * schedule on enter to avoid running before vim first buffer has loaded * update docs * correct typo * rename tab open -> open on tab

…on a closed folder while creating files (nvim-tree#628)

the new setup refactoring might have some issues when users require the tree before setting up global options, which might result in a startup check not detecting those out of date options.

- put renderer into its own folder, extract the padding logic to make it reloadable. Will allow small refactorings of the rendering logic to make it easier to extend. - get the icon state before each renderer reload

…into kyazdani42-master

jim-fx · 2021-09-28T13:21:46Z

Hi @kyazdani42

I had some time today to work on this pull request.
The hide_root_folder option is now part of the setup function and not global anymore.

I was unsure how to pass the hide_root_folder boolean from the nvim-tree.setup function to the places where I needed to access it, so i added it to the view.View object. There is probably a better way to do this, but it works.

Sorry to cause some problems with the indentations and linting, i just started learning lua a few weeks ago and i dont really know how to setup those things to work correctly.

Anyway hope this is mergable and you all have a good day,

Cheers ✌, Jim

kyazdani42 · 2021-09-29T19:11:18Z

@jim-fx looks like there are still formatting issues. I could take this PR and format it properly because it looks ok otherwise, what do you think ?

jim-fx · 2021-09-30T17:59:25Z

For learning purposes, I tried to fix the warnings from luacheck myself. Other than that you can do anything you want before you merge the pr.

kyazdani42 · 2021-10-02T18:37:06Z

please rebase again :)

jim-fx · 2021-10-02T23:28:58Z

@kyazdani42 just did :)

kyazdani42

Can you please rebase the PR and not merge the master in it ? You'd have had less issues.
If you don't know much about rebasing, i'd suggest this small exercise

kyazdani42 · 2021-10-03T11:04:28Z

doc/nvim-tree-lua.txt

@@ -78,6 +78,7 @@ function.
      open_on_tab         = false,
      hijack_cursor       = false,
      update_cwd          = false,
+			hide_root_folder		= false,


indenting :)

kyazdani42 · 2021-10-03T11:05:23Z

doc/nvim-tree-lua.txt

@@ -200,7 +201,10 @@ Here is a list of the options available in the setup call:
    type: `boolean`
    default: false

-*nvim-tree.view*
+- |hide_root_folder|: hide the path of the current working directory on top of the tree


badly resolved, add a *nvim-tree.hide_root_folder* above your option declaration and do not remove the *nvim-tree.view* before the view declaration :)

kyazdani42 · 2021-10-03T11:05:45Z

lua/nvim-tree.lua

@@ -161,8 +161,15 @@ function M.on_keypress(mode)
    return keypress_funcs[mode](node)
  end

+	local hide_root_folder = view.View.hide_root_folder
+
+


too many empty lines here, one suffice :)

kyazdani42 · 2021-10-03T11:06:27Z

lua/nvim-tree.lua

  if node.name == ".." then
-    return lib.change_dir("..")
+		if hide_root_folder then


missing or node.name ~= '..'

kyazdani42 · 2021-10-03T11:07:08Z

lua/nvim-tree.lua

@@ -408,7 +415,8 @@ local DEFAULT_OPTS = {
  hijack_cursor       = false,
  update_cwd          = false,
  lsp_diagnostics     = false,
-  update_focused_file = {
+  hide_root_folder		= false,
+	update_focused_file = {


badly aligned :)

kyazdani42 · 2021-10-03T11:09:44Z

lua/nvim-tree/lib.lua

@@ -205,7 +212,8 @@ end

 function M.set_index_and_redraw(fname)
  local i
-  if M.Tree.cwd == '/' then
+	local hide_root_folder = view.View.hide_root_folder
+  if M.Tree.cwd == '/' and hide_root_folder then


why is this an and and not an or ?

lua/nvim-tree/renderer/init.lua

kyazdani42 · 2021-10-03T11:10:44Z

lua/nvim-tree/view.lua

@@ -9,6 +9,7 @@ end
 M.View = {
  bufnr = nil,
  tabpages = {},
+	hide_root_folder = false,


missing space.

kyazdani42 · 2021-10-03T11:10:50Z

lua/nvim-tree/view.lua

@@ -107,7 +108,7 @@ end
 local DEFAULT_CONFIG = {
  width = 30,
  side = 'left',
-  auto_resize = false,
+	auto_resize = false,


unwanted change

kyazdani42 · 2021-10-03T11:10:56Z

lua/nvim-tree/view.lua

@@ -141,7 +142,7 @@ function M.setup(opts)
  local options = vim.tbl_deep_extend('force', DEFAULT_CONFIG, opts)
  M.View.side = options.side
  M.View.width = options.width
-  M.View.auto_resize = opts.auto_resize
+	M.View.auto_resize = opts.auto_resize


subterfugue · 2021-10-16T00:04:27Z

Hey, not to rush you, but it seems there's no more activity on this - if you wish, I can attempt to help merge this? This is a nice feature that I'd love to have in nvim-tree. Sorry if this sounds rude.

kyazdani42 · 2021-10-16T15:43:54Z

code has changed much, you could reimplement this if the author does not give any news

jim-fx · 2021-10-16T16:06:24Z

Hey, not to rush you, but it seems there's no more activity on this - if you wish, I can attempt to help merge this? This is a nice feature that I'd love to have in nvim-tree. Sorry if this sounds rude.

Hi, dont worry did not sound rude at all. I am currently very busy with university, so i will not have a lot of time the next few weeks. I think i sort of underestimated how much effort this takes with my lua skills.

If you would like to implement it yourself, please go ahead. Otherwise i will probably try again in a few weeks, Cheers 👋

kyazdani42 · 2021-10-16T16:12:12Z

not only lua skills but codebase is hard to read imo, it started off as a learning project for lua, now i'm rewriting the whole thing bit by bit 😄

subterfugue · 2021-10-16T21:07:34Z

I have finished the functionality and added some "documentation" in - though I am rather unsure of how good it is - I depend on you to review and say your preference, since I am quite new to writing documentation with Vim syntax. The repo is https://github.com/MonAaraj/nvim-tree.lua - I believe I need to create a new pull request for this? I'm not quite sure, if I need to do so, please tell me here.

kyazdani42 · 2021-10-17T08:43:39Z

make a new PR it'll be easier :)

jim-fx · 2021-10-17T11:27:34Z

Duplicated to #728

feat: add option to hide root dir path

2ad3e33

kyazdani42 reviewed Sep 25, 2021

View reviewed changes

frogtile and others added 22 commits September 28, 2021 14:48

Update README.md (nvim-tree#621)

4d62ac2

Only renders the git icon if the icon is not empty (nvim-tree#633)

7f148f1

fix: lsp_diagnostics switch reversed. (nvim-tree#635)

4be0a36

fix: open view on NvimTreeFindFile

aa6e674

chore: lsp diagnostics setup

5ee7324

feat: option to set path destination to parent folder when cursor is …

dd880e3

…on a closed folder while creating files (nvim-tree#628)

fix: defer the options check

c588e96

the new setup refactoring might have some issues when users require the tree before setting up global options, which might result in a startup check not detecting those out of date options.

chore/fix: renderer module initializations

9f7b563

- put renderer into its own folder, extract the padding logic to make it reloadable. Will allow small refactorings of the rendering logic to make it easier to extend. - get the icon state before each renderer reload

fix: remove buffer when replacing window

e19eb5c

chore: refacto view setup and simplify the code

ddd80af

fix: remove tip from readme because we can use NvimTreeResize

6f35805

Remove duplicate 'nvim-tree-options' tag. (nvim-tree#642)

0236b53

fix: help after refactoring view (nvim-tree#647)

c73186c

fix: highlight git new file icon with gitnew not gitdirty

3ed80fd

fix: renderer global options should be loaded on each reload

08b351a

docfix: remove EOF tag

d969239

refactor: move options into function

a5724d5

refactor: move hide_root_folder option out of view options

2ec39bc

Merge branch 'master' of https://github.com/kyazdani42/nvim-tree.lua …

8cba74a

…into kyazdani42-master

Merge branch 'kyazdani42-master'

8a1d7b1

fix: wrong indentations in readme

fdd632b

jim-fx added 3 commits September 30, 2021 19:54

fix: make linter happy

e1b13f5

Merge branch 'kyazdani42:master' into master

e8a0379

Merge branch 'master' of github.com:jim-fx/nvim-tree.lua

a99ca2a

Merge branch 'master' of https://github.com/kyazdani42/nvim-tree.lua

0022cd7

kyazdani42 requested changes Oct 3, 2021

View reviewed changes

subterfugue mentioned this pull request Oct 17, 2021

feat: add hide_root_folder #728

Merged

jim-fx closed this Oct 17, 2021

Uh oh!

feat: add option to hide root dir path #631

feat: add option to hide root dir path #631

Uh oh!

Conversation

jim-fx commented Sep 23, 2021

Uh oh!

kyazdani42 left a comment

Choose a reason for hiding this comment

Uh oh!

kunish commented Sep 27, 2021

Uh oh!

jim-fx commented Sep 28, 2021

Uh oh!

kyazdani42 commented Sep 29, 2021

Uh oh!

jim-fx commented Sep 30, 2021

Uh oh!

kyazdani42 commented Oct 2, 2021

Uh oh!

jim-fx commented Oct 2, 2021

Uh oh!

kyazdani42 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

subterfugue commented Oct 16, 2021

Uh oh!

kyazdani42 commented Oct 16, 2021

Uh oh!

jim-fx commented Oct 16, 2021

Uh oh!

kyazdani42 commented Oct 16, 2021

Uh oh!

subterfugue commented Oct 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kyazdani42 commented Oct 17, 2021

Uh oh!

jim-fx commented Oct 17, 2021

Uh oh!

Uh oh!

subterfugue commented Oct 16, 2021 •

edited

Loading