Fix tree refreshing logic #739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains one commit to fix an issue in the logic that is used to prevent too many refreshes during a short period of time.
Before this commit, when
lib.refresh_tree()
is called withdisable_clock = true
(for example by typingR
in the tree's window),refreshing
gets set totrue
. However, nothing setsrefreshing
tofalse
afterwards because theif
statement evaluates tofalse
. This results in subsequent calls tolib.refresh_tree()
withdisable_clock = false
(for example through:NvimTreeRefresh
) to exit the function early and therefore not actually update the tree.The proposed fix in this commit is to simply set
refreshing
tofalse
unconditionally (i.e., regardless of thedisable_clock
value).P.S.: Thank you for you for creating and maintaining this great plugin!