Skip to content

ci: stop testing against NodeJS v18 #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025
Merged

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented May 12, 2025

BREAKING CHANGE: Drop support for NodeJS v18

@wolfy1339 wolfy1339 added Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels May 12, 2025
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 force-pushed the remove-eol-node-versions branch from abd08b4 to a95129b Compare May 12, 2025 19:38
@wolfy1339 wolfy1339 changed the title ci: stop testing against NodeJS v10, v12, v14, v16, v18 ci: stop testing against NodeJS v18 May 12, 2025
@wolfy1339 wolfy1339 force-pushed the remove-eol-node-versions branch 2 times, most recently from f4cc845 to 1c6eb1e Compare May 12, 2025 20:21
@wolfy1339 wolfy1339 force-pushed the remove-eol-node-versions branch from 1c6eb1e to 8f213c0 Compare May 12, 2025 22:13
@oscard0m oscard0m merged commit 0b0bb9c into main May 20, 2025
13 checks passed
@oscard0m oscard0m deleted the remove-eol-node-versions branch May 20, 2025 06:34
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active May 20, 2025
Copy link
Contributor

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Julesssss added a commit to Julesssss/plugin-paginate-rest.js that referenced this pull request Jun 5, 2025
* main:
  fix(deps): update `@octokit/types` - no new paginated endpoints (octokit#680)
  chore(deps): update octokit monorepo (major) (octokit#679)
  ci: stop testing against NodeJS v18 (octokit#677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants