Skip to content

fix: adapt for latest @octokit/types #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 3, 2020
Merged

fix: adapt for latest @octokit/types #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9374ed3
build(deps): bump @octokit/types from 6.0.0 to 6.0.1
dependabot[bot] Dec 2, 2020
193767f
fix: adapt for latest @octokit/types
gr2m Dec 2, 2020
68c02f9
build(package): lock file
gr2m Dec 2, 2020
6ba35a4
test: adapt for latest @octokit/types
gr2m Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
171 changes: 85 additions & 86 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"author": "Gregor Martynus (https://twitter.com/gr2m)",
"license": "MIT",
"dependencies": {
"@octokit/types": "^6.0.0",
"@octokit/types": "^6.0.3",
"deprecation": "^2.3.1"
},
"devDependencies": {
Expand Down
16 changes: 7 additions & 9 deletions test/rest-endpoint-methods.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ describe("REST API endpoint methods", () => {
it("README example", async () => {
const mock = fetchMock.sandbox().post(
"path:/user/repos",
{ ok: true },
{ id: 1 },
{
body: {
name: "my-new-repo",
Expand All @@ -28,19 +28,17 @@ describe("REST API endpoint methods", () => {
name: "my-new-repo",
});

expect(data).toStrictEqual({ ok: true });
expect(data.id).toStrictEqual(1);
});

it("Required preview header", async () => {
const mock = fetchMock.sandbox().getOnce(
"path:/codes_of_conduct",
{ ok: true },
{
const mock = fetchMock
.sandbox()
.getOnce("path:/codes_of_conduct", [{ key: "mit" }], {
headers: {
accept: "application/vnd.github.scarlet-witch-preview+json",
},
}
);
});

const MyOctokit = Octokit.plugin(restEndpointMethods);
const octokit = new MyOctokit({
Expand All @@ -52,7 +50,7 @@ describe("REST API endpoint methods", () => {
// See https://developer.github.com/v3/repos/#create-a-repository-dispatch-event
const { data } = await octokit.codesOfConduct.getAllCodesOfConduct();

expect(data).toStrictEqual({ ok: true });
expect(data[0].key).toStrictEqual("mit");
});

it("octokit.markdown.renderRaw()", async () => {
Expand Down