Skip to content

feat: codeScanning.listAlertInstances(), actions.approveWorkflowRun(). Deprecates codeScanning.listAlertsInstances() #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 21, 2021

Conversation

octokitbot
Copy link
Contributor

If there are any new endpoints, then the code changes will likely required an update of @octokit/types. It should have received a pull request as well, merge & release it first. The @octokit/types should be updated automatically shortly after in this pull request.

Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.

In general

  • Avoid breaking changes at all costs
  • If there are no typescript or code changes, use a docs prefix
  • If there are typescript changes but no code changes, use fix(typescript) prefix
  • If there are code changes, use fix if a problem was resolved, feat if new endpoints / parameters were added, and feat(deprecation) if a method was deprecated.

],
listAlertsForRepo: ["GET /repos/{owner}/{repo}/code-scanning/alerts"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not have been added.

@gr2m gr2m self-assigned this Apr 30, 2021
@github-actions github-actions bot dismissed a stale review via 2d22947 May 1, 2021 20:28
@github-actions github-actions bot dismissed a stale review via 6df4d88 May 4, 2021 18:07
@github-actions github-actions bot dismissed a stale review via 6867003 May 7, 2021 20:31
@github-actions github-actions bot dismissed a stale review via f006f0a May 8, 2021 16:21
@github-actions github-actions bot dismissed a stale review via 9d843b6 May 11, 2021 19:39
@github-actions github-actions bot dismissed a stale review via 4e7b34f May 12, 2021 18:25
@gr2m gr2m dismissed a stale review via 017e11c May 21, 2021 20:08
@gr2m gr2m changed the title 🚧 GitHub OpenAPI specifications changed feat: codeScanning.listAlertInstances(), actions.approveWorkflowRun(). Deprecates codeScanning.listAlertsInstances() May 21, 2021
gr2m
gr2m previously approved these changes May 21, 2021
@github-actions github-actions bot dismissed stale reviews from gr2m and ghost via c25a6c7 May 21, 2021 20:36
@gr2m gr2m dismissed a stale review via 9d9a239 May 21, 2021 20:40
@gr2m gr2m dismissed a stale review via 84fa594 May 21, 2021 20:42
@gr2m gr2m force-pushed the openapi-update branch from 9d9a239 to 84fa594 Compare May 21, 2021 20:42
@gr2m gr2m dismissed a stale review via 3659fa3 May 21, 2021 20:43
@gr2m gr2m dismissed a stale review via 5b687ab May 21, 2021 20:47
@gr2m gr2m merged commit e8087b4 into master May 21, 2021
@gr2m gr2m deleted the openapi-update branch May 21, 2021 20:51
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants