fix(fetch-wrapper): improve error message when 'fetch' implementation is not present #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on is not present
oscard0m
added
the
Type: Maintenance
5 tasks
wolfy1339
approved these changes
Jul 15, 2023
gr2m
changed the title
gr2m
requested changes
Jul 18, 2023
There was a problem hiding this comment.
I changed to commit message to a fix, as it's changing behavior in production.
I block the pull request just in case as we should merge octokit/octokit.js#2502 first
|
octokit/octokit.js#2502 should be g2g in my opinion. Thank you for getting this knocked out @oscard0m ❤️ |
nickfloyd
approved these changes
Jul 18, 2023
gr2m
approved these changes
Jul 19, 2023
oscard0m
deleted the
improve-message-when-no-fetch-implementation-is-present
branch
|
🎉 This PR is included in version 8.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #616
Behavior
Before the change?
Not very clear error message when
fetchimplementation is missingAfter the change?
Improved error message when
fetchimplementation is missingOther information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Type: Maintenance