Skip to content

ci(workflows): add write permissions to release workflow #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 9, 2024

Resolves #672


Before the change?

After the change?

  • Hopefully it'll be able to release...

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

github-actions bot commented Feb 9, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@jsoref
Copy link
Contributor Author

jsoref commented Feb 9, 2024

Actually, it apparently needs more than that...

@jsoref jsoref force-pushed the add-contents-write-to-release-workflow branch from a31526c to f16ed86 Compare February 9, 2024 12:55
@jsoref
Copy link
Contributor Author

jsoref commented Feb 9, 2024

Ok, w/ those two permissions, my fork is able to get a ✅ https://github.com/jsoref/request.js/actions/runs/7844257545.

And boy it is so much nicer with the changes integrated -- figuring out what's missing is trivial! Now I just need to get everyone to upgrade.

@wolfy1339 wolfy1339 merged commit 07b6259 into octokit:main Feb 9, 2024
@jsoref jsoref deleted the add-contents-write-to-release-workflow branch February 9, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: release.yml needs contents: write
2 participants