Skip to content

add user-friendly compiler checks to the CMakelists.txt #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2023
Merged

add user-friendly compiler checks to the CMakelists.txt #8

merged 1 commit into from
Nov 13, 2023

Conversation

haichangsi
Copy link
Contributor

No description provided.

@haichangsi haichangsi requested a review from mateuszpn November 7, 2023 09:33
@haichangsi haichangsi self-assigned this Nov 7, 2023
@haichangsi haichangsi removed the request for review from mateuszpn November 7, 2023 09:37
mateuszpn
mateuszpn reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@mateuszpn mateuszpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion only checking the -fsycl flag is really mandatory.

@lslusarczyk lslusarczyk linked an issue Nov 8, 2023 that may be closed by this pull request
User-friendly checks in tutorial's cmake #7
Closed
@haichangsi haichangsi merged commit 717acdd into oneapi-src:main Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszpn mateuszpn mateuszpn left review comments

Assignees

@haichangsi haichangsi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User-friendly checks in tutorial's cmake
2 participants
@haichangsi @mateuszpn