[oneMKL][RNG] Samples clean up for RNG, add new sample. #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkitez
reviewed
Sep 16, 2020
Libraries/oneMKL/random_sampling_without_replacement/sample.json
Outdated
Show resolved
Hide resolved
anjgola
requested review from
a team,
JoeOster and
srdontha
and removed request for
a team
JoeOster
reviewed
Sep 22, 2020
JoeOster
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
W/a is added for reduce function (namespace changes from sycl::intel to sycl::ONEAPI::)
European option pricing sample is cleaned and aligned with pi number evaluation sample
Add new RNG sample: Multiple Simple Random Sampling without replacement
Fixes # (issue)
Type of change
How Has This Been Tested?
Manually tests for Linux and Windows CPU and GPU with oneMKL beta08 and oneMKL beta09 functionality