Update Fortran combinational logic openmp-primes sample #1797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update sample for ifx - Formatting updates - Minor editorial updates Signed-off-by: Kristal Dale <[email protected]>
jimmytwei
reviewed
Jul 18, 2023
| @@ -3,23 +3,23 @@ | |||
| "name": "OpenMP* Primes", | |||
| "categories": ["Toolkit/oneAPI Direct Programming/Fortran/Combinational Logic"], | |||
| "description": "Fortran Tutorial - Using OpenMP* (OMP)", | |||
| "toolchain": [ "ifort" ], | |||
| "toolchain": [ "ifx" ], | |||
| "languages": [ { "fortran": {} } ], | |||
| "targetDevice": [ "CPU" ], | |||
| "os": [ "darwin" ], | |||
There was a problem hiding this comment.
@krisdale Can you remove darwin from os and add in both linux and windows?
Ex: "os": ["linux", "windows"],
jimmytwei
reviewed
Jul 18, 2023
| @@ -3,23 +3,23 @@ | |||
| "name": "OpenMP* Primes", | |||
| "categories": ["Toolkit/oneAPI Direct Programming/Fortran/Combinational Logic"], | |||
| "description": "Fortran Tutorial - Using OpenMP* (OMP)", | |||
| "toolchain": [ "ifort" ], | |||
| "toolchain": [ "ifx" ], | |||
| "languages": [ { "fortran": {} } ], | |||
| "targetDevice": [ "CPU" ], | |||
| "os": [ "darwin" ], | |||
| "builder": [ "make" ], | |||
| "ciTests":{ | |||
| "darwin": [ | |||
There was a problem hiding this comment.
@krisdale Can you add the build steps for Linux and Windows? Remove darwin and add linux and windows.
1 task
Signed-off-by: Kristal Dale <[email protected]>
Update CI steps for Linux and Windows. Remove Darwin. Signed-off-by: Kristal Dale <[email protected]>
|
Thanks for the review @jimmytwei - updates applied. |
jimmytwei
approved these changes
Jul 31, 2023
|
@krisdale Approved. Sample works with the latest (7/31/23) 2024.0 BaseKit and HPCKit. Merging into development branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Type of change