Adapt to the get_pointer return type change from upstream intel/llvm
#1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuoniu-intel
changed the title
get_pointer return type change from upstream intel/llvm
whitepau
suggested changes
Aug 3, 2023
DirectProgramming/C++SYCL_FPGA/Tutorials/Features/lsu_control/README.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The upstream commit intel/llvm#8874 changed the return type of
accessor::get_pointerfrom amulti_ptrto a raw pointer, which affects all uses oflsu::loadandlsu::storewho expect amulti_ptras their first function argument.This commit updates the two affected code samples (lsu_control, latency_control) to avoid the compile failure caused by pointer type mismatch between
accessor::get_pointerandlsu::load/lsu::store.Fixes Issue https://jira.devtools.intel.com/browse/HLD-2916.
Case tracker for improving LSU control API in the future: https://hsdes.intel.com/appstore/article/#/14020028781.
Type of change
How Has This Been Tested?