Skip to content

Fortran for macOS 3 samples DRAFT #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 21, 2020
Merged

Conversation

greenrongreen
Copy link
Contributor

Initial DRAFT Fortran macOS samples (3). vec_samples optimize_samples. openmp_samples

@anjgola
Copy link
Contributor

anjgola commented Jul 10, 2020

Can you please un-draft this so that CI can run.

@greenrongreen
Copy link
Contributor Author

greenrongreen commented Jul 10, 2020 via email

@greenrongreen greenrongreen marked this pull request as ready for review July 13, 2020 21:34
@greenrongreen
Copy link
Contributor Author

These 3 samples were ported over from our Parallel Studio XE samples, for macOS.
These work with the early build of the oneAPI Base + HPC kit for macOS.
As an FYI they would work with Linux also but I was only asked for macOS.

Do we need to ask Paul Petersen to review also??

@JoeOster
Copy link
Contributor

Paul Petereson should review as well

Copy link
Contributor

@JoeOster JoeOster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an old-style readme and needs updating. Please work with Tom Lenth for details. One example of a up to date readme is here:

@greenrongreen
Copy link
Contributor Author

3 json files were edited to include CI stanzas. those 3 files pushed today.

@greenrongreen
Copy link
Contributor Author

@JoeOster I have pushed the revised 3 README.md files that match your example's outline

JoeOster
JoeOster previously approved these changes Jul 17, 2020
mkitez
mkitez previously approved these changes Jul 20, 2020
@greenrongreen
Copy link
Contributor Author

ah, I did not know about jsonlint. I have a fix to push

@anjgola anjgola merged commit 6a0f521 into oneapi-src:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants