Skip to content

Commit 3c03e2b

Browse files
Merge pull request #679 from ldorau/Fix_umf_standalone_examples_test
Fix umf_standalone_examples test
2 parents 5aff745 + 13acb6f commit 3c03e2b

File tree

2 files changed

+22
-18
lines changed

2 files changed

+22
-18
lines changed

test/CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,13 +440,14 @@ if(LINUX
440440
)
441441
endif()
442442

443-
if(NOT UMF_DISABLE_HWLOC)
443+
if(EXAMPLES AND NOT UMF_DISABLE_HWLOC)
444444
add_test(
445445
NAME umf_standalone_examples
446446
COMMAND
447447
${UMF_CMAKE_SOURCE_DIR}/test/test_examples.sh
448448
${UMF_CMAKE_SOURCE_DIR} ${CMAKE_BINARY_DIR}
449-
${CMAKE_INSTALL_PREFIX} ${EXAMPLES}
449+
${CMAKE_CURRENT_BINARY_DIR}/umf_standalone_examples/install-dir
450+
"${CMAKE_INSTALL_PREFIX}" ${EXAMPLES}
450451
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
451452
endif()
452453
endif()

test/test_examples.sh

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,53 +5,56 @@
55

66
set -e
77

8-
WORKSPACE=$1
8+
SOURCE_DIR=$1
99
BUILD_DIR=$2
1010
INSTALL_DIR=$3
11+
CMAKE_INSTALL_PREFIX=$4
1112

1213
echo "Running: $0 $*"
1314

1415
function print_usage() {
1516
echo "$(basename $0) - test all examples standalone"
16-
echo "Usage: $(basename $0) <workspace_dir> <build_dir> <install_dir> <list-of-examples-to-run>"
17+
echo "Usage: $(basename $0) <source_dir> <build_dir> <install_dir> <CMAKE_INSTALL_PREFIX> <list-of-examples-to-run>"
1718
}
1819

19-
if [ "$3" == "" ]; then
20+
if [ "$5" == "" ]; then
2021
print_usage
2122
echo -e "Error: too few arguments\n"
2223
exit 1
2324
fi
2425

25-
if [ "$4" == "" ]; then
26-
print_usage
27-
echo "No examples to run!"
28-
exit 0
29-
fi
30-
31-
if [ ! -f $WORKSPACE/README.md ]; then
32-
echo -e "error: incorrect <workspace_dir>: $WORKSPACE\n"
26+
if [ ! -f $SOURCE_DIR/README.md ]; then
27+
echo -e "error: incorrect <source_dir>: $SOURCE_DIR\n"
3328
print_usage
3429
exit 1
3530
fi
3631

37-
WORKSPACE=$(realpath $WORKSPACE)
32+
mkdir -p ${INSTALL_DIR}/${CMAKE_INSTALL_PREFIX}
33+
34+
SOURCE_DIR=$(realpath $SOURCE_DIR)
3835
BUILD_DIR=$(realpath $BUILD_DIR)
3936
INSTALL_DIR=$(realpath $INSTALL_DIR)
4037

41-
shift 3
38+
echo "SOURCE_DIR=$SOURCE_DIR"
39+
echo "BUILD_DIR=$BUILD_DIR"
40+
echo "CMAKE_INSTALL_PREFIX=$CMAKE_INSTALL_PREFIX"
41+
echo "INSTALL_DIR=$INSTALL_DIR"
42+
43+
shift 4
4244
EXAMPLES="$*"
4345
echo "Examples to run: $EXAMPLES"
4446
echo
4547

4648
cd ${BUILD_DIR}
4749
echo "DIR=$(pwd)"
4850

51+
echo "Installing UMF into the directory: ${INSTALL_DIR}/${CMAKE_INSTALL_PREFIX}"
4952
set -x
50-
make -j$(nproc) install
53+
make DESTDIR=$INSTALL_DIR -j$(nproc) install
5154
set +x
5255

5356
for ex in $EXAMPLES; do
54-
SRC_DIR="${WORKSPACE}/examples/$ex"
57+
SRC_DIR="${SOURCE_DIR}/examples/$ex"
5558
BLD_DIR="${BUILD_DIR}/examples-standalone/$ex"
5659

5760
if [ ! -d $SRC_DIR ]; then
@@ -67,7 +70,7 @@ for ex in $EXAMPLES; do
6770
rm -rf $BLD_DIR
6871
mkdir -p $BLD_DIR
6972
cd $BLD_DIR
70-
CMAKE_PREFIX_PATH="$INSTALL_DIR" cmake $SRC_DIR
73+
CMAKE_PREFIX_PATH="${INSTALL_DIR}/${CMAKE_INSTALL_PREFIX}" cmake $SRC_DIR
7174
make -j$(nproc)
7275
ctest --output-on-failure
7376
set +x

0 commit comments

Comments
 (0)