Skip to content

Fix umf_standalone_examples test #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix umf_standalone_examples test #679

merged 2 commits into from
Sep 3, 2024

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Aug 14, 2024 •
edited
Loading

Description

Fix the umf_standalone_examples test.
Install UMF into a new directory created inside CMAKE_CURRENT_BINARY_DIR.

Fixes: #674

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau requested a review from a team as a code owner August 14, 2024 11:22
@ldorau ldorau mentioned this pull request Aug 14, 2024
Closed
lplewa
lplewa reviewed Aug 14, 2024
View reviewed changes
@ldorau
Replace two names of variables in test/test_examples.sh
352bb22 
Replace names of the following variables:
- WORKSPACE with SOURCE_DIR
- workspace_dir with source_dir

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Fix_umf_standalone_examples_test branch 2 times, most recently from dba7673 to 5becbc6 Compare August 14, 2024 17:36
@ldorau
Copy link
Contributor Author

ldorau commented Aug 14, 2024

I will be back on September 2nd.

@ldorau ldorau force-pushed the Fix_umf_standalone_examples_test branch from 5becbc6 to ba937a2 Compare August 14, 2024 21:26
lukaszstolarczuk
lukaszstolarczuk reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my general comment is - this seems a little too complicated - we could go the other way and only test standalone examples as part of our installation_test, and run it in CI

@ldorau
Copy link
Contributor Author

ldorau commented Sep 2, 2024

my general comment is - this seems a little too complicated - we could go the other way and only test standalone examples as part of our installation_test, and run it in CI

OK, so you can propose an alternate solution.

PatKamin
PatKamin reviewed Sep 3, 2024
View reviewed changes
@ldorau
Fix umf_standalone_examples test
13acb6f 
Install UMF into a new directory
created inside CMAKE_CURRENT_BINARY_DIR.

Fixes: oneapi-src#674

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Fix_umf_standalone_examples_test branch from ba937a2 to 13acb6f Compare September 3, 2024 10:59
@lukaszstolarczuk lukaszstolarczuk merged commit 3c03e2b into oneapi-src:main Sep 3, 2024
66 checks passed
@ldorau ldorau deleted the Fix_umf_standalone_examples_test branch September 4, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lplewa lplewa lplewa left review comments

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

@PatKamin PatKamin PatKamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standalone examples test install umf in user system, without user consent
4 participants
@ldorau @lplewa @lukaszstolarczuk @PatKamin