Skip to content

Remove unnecessary commas due to removing pedantic option #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2024
Merged

Remove unnecessary commas due to removing pedantic option #1010

merged 1 commit into from
Dec 20, 2024

Conversation

KFilipek
Copy link
Contributor

This commit reverts changes that can make code reading more difficult.

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@KFilipek
Remove unnecessary commas due to removing pedantic option
d93b3d7 
This commit reverts changes that can make code reading
more difficult.
@KFilipek KFilipek requested a review from lplewa December 19, 2024 13:33
@KFilipek KFilipek self-assigned this Dec 19, 2024
@KFilipek KFilipek marked this pull request as ready for review December 20, 2024 13:01
@KFilipek KFilipek requested a review from a team as a code owner December 20, 2024 13:01
@ldorau ldorau merged commit 1a5155f into oneapi-src:main Dec 20, 2024
77 checks passed
@KFilipek KFilipek deleted the remove-macro-commas branch December 20, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldorau ldorau ldorau approved these changes

@lplewa lplewa lplewa approved these changes

Assignees

@KFilipek KFilipek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KFilipek @ldorau @lplewa