-
Notifications
You must be signed in to change notification settings - Fork 35
Make ICX enabled again #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ICX enabled again #1030
Conversation
This reverts commit e8cde28.
6ed3b8e
to
c480959
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heh, I appreciate using my branch for this PR, but it contains a test commit "[CI] test only icx" - I guess it should be removed ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beside copyright and removing redundant commit - LGTM
I left it intentionally because it was also your work :P |
Partially reverts changes from: oneapi-src#1030
Description
There is a problem with linkage under icx/icpx due to linking against compiler libs.
When executing tests without sourced paths to compiler (prevents from loading compiler version of UMF) there are errors of missing symbols/libs.
Considerations
There was 2 options:
-static-intel
-no-intel-lib
(more info) or using another option-Wl,-as-needed'
First works like a charm, but the UMF contains icx/icpx needed dependencies compiled in, I don't know it's a problem or not.
Last option require to force
gtest
to compile the same way - without Intel compiler dependencies (e.g.svml
,imf
etc). According togtest
documentation we can shareCMAKE_(C/CXX)_FLAGS
. Another approach is to split steps and apply patch.Fixes #843
Checklist