Skip to content

add a workflow for running UMF benchmarks #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2025
Merged

add a workflow for running UMF benchmarks #1060

merged 2 commits into from
Jan 31, 2025

Conversation

EuphoricThinking
Copy link
Contributor

@EuphoricThinking EuphoricThinking commented Jan 24, 2025 •
edited by lukaszstolarczuk
Loading

Downloads scripts for data visualisation from UR repository, run UMF benchmarks, upload the results to GitHub pages.

When commenting out Windows benchmark setup, I was inspired by nightly.yml

Enjoy charts: https://euphoricthinking.github.io/unified-memory-framework/benchmark_results.html?suites=UMF

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@EuphoricThinking EuphoricThinking requested a review from a team as a code owner January 24, 2025 19:02
PatKamin
PatKamin reviewed Jan 27, 2025
View reviewed changes
PatKamin
PatKamin reviewed Jan 27, 2025
View reviewed changes
PatKamin
PatKamin reviewed Jan 27, 2025
View reviewed changes
PatKamin
PatKamin reviewed Jan 27, 2025
View reviewed changes
PatKamin
PatKamin reviewed Jan 27, 2025
View reviewed changes
@EuphoricThinking EuphoricThinking force-pushed the benchmark_p9_11_workflow_review1 branch 2 times, most recently from 4144f8a to c7293f4 Compare January 27, 2025 13:42
@EuphoricThinking
add template for Windows benchmarks
378d1a3 
problems with adding comments to PR
to be fixed
@EuphoricThinking EuphoricThinking force-pushed the benchmark_p9_11_workflow_review1 branch from c7293f4 to ad6a010 Compare January 27, 2025 14:04
PatKamin
PatKamin approved these changes Jan 27, 2025
View reviewed changes
@EuphoricThinking EuphoricThinking force-pushed the benchmark_p9_11_workflow_review1 branch from ad6a010 to a153477 Compare January 27, 2025 15:39
lukaszstolarczuk
lukaszstolarczuk requested changes Jan 27, 2025
View reviewed changes
@EuphoricThinking EuphoricThinking force-pushed the benchmark_p9_11_workflow_review1 branch from a153477 to 0e3f3cc Compare January 28, 2025 12:28
@EuphoricThinking EuphoricThinking marked this pull request as draft January 28, 2025 12:38
@EuphoricThinking EuphoricThinking force-pushed the benchmark_p9_11_workflow_review1 branch 4 times, most recently from 49498d8 to d7650c4 Compare January 29, 2025 10:25
@EuphoricThinking EuphoricThinking marked this pull request as ready for review January 29, 2025 10:32
lukaszstolarczuk
lukaszstolarczuk reviewed Jan 29, 2025
View reviewed changes
@EuphoricThinking EuphoricThinking force-pushed the benchmark_p9_11_workflow_review1 branch 2 times, most recently from 95677fb to 6175798 Compare January 29, 2025 15:55
@EuphoricThinking
add workflow for running UMF benchmarks on Ubuntu
ccb2156 
download scripts for data visualisation from UR repository,
run UMF benchmarks, upload the results to GitHub pages
@EuphoricThinking EuphoricThinking force-pushed the benchmark_p9_11_workflow_review1 branch from 6175798 to ccb2156 Compare January 29, 2025 16:44
lukaszstolarczuk
lukaszstolarczuk approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general, LGTM, we can merge it as is

.github/workflows/benchmarks.yml
@@ -0,0 +1,31 @@
name: Compute Benchmarks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teeny, tiny thing to consider: for UMF we don't execute "Compute Benchmarks" - we execute our benchmarks written with gtest. We could consider renaming it (in all places, incl. writing comments, etc...)

@lukaszstolarczuk lukaszstolarczuk merged commit 504ca01 into oneapi-src:main Jan 31, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

@PatKamin PatKamin PatKamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EuphoricThinking @lukaszstolarczuk @PatKamin