Skip to content

Add LIBHWLOC_INCLUDE_DIRS to build_umf_test() #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Jan 31, 2025

Description

Add LIBHWLOC_INCLUDE_DIRS to build_umf_test()
when UMF_LINK_HWLOC_STATICALLY is ON.

Ref: #1065

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau requested a review from a team as a code owner January 31, 2025 12:23
Add LIBHWLOC_INCLUDE_DIRS to build_umf_test()
when UMF_LINK_HWLOC_STATICALLY is ON.

Ref: oneapi-src#1065

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Add_LIBHWLOC_INCLUDE_DIRS_to_build_umf_test branch from 201301c to a50be2c Compare January 31, 2025 12:33
@ldorau
Copy link
Contributor Author

ldorau commented Jan 31, 2025

Ref: #1065

@ldorau
Copy link
Contributor Author

ldorau commented Jan 31, 2025

@PatKamin please review this fix for the #1065 issue

Copy link
Contributor

@PatKamin PatKamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@lukaszstolarczuk lukaszstolarczuk merged commit 9377fd0 into oneapi-src:main Jan 31, 2025
76 checks passed
@ldorau ldorau deleted the Add_LIBHWLOC_INCLUDE_DIRS_to_build_umf_test branch January 31, 2025 14:40
ldorau added a commit to ldorau/unified-memory-framework that referenced this pull request Feb 3, 2025
LIBHWLOC_INCLUDE_DIRS should be used always
when hwloc is not disabled.

Ref: oneapi-src#1066

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-memory-framework that referenced this pull request Feb 3, 2025
LIBHWLOC_INCLUDE_DIRS should be used always
when hwloc is not disabled.

Ref: oneapi-src#1066

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-memory-framework that referenced this pull request Feb 3, 2025
LIBHWLOC_INCLUDE_DIRS should be used always
when hwloc is not disabled.

Ref: oneapi-src#1066

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau added a commit to ldorau/unified-memory-framework that referenced this pull request Feb 14, 2025
LIBHWLOC_INCLUDE_DIRS should be used always
when hwloc is not disabled.

Ref: oneapi-src#1066

Signed-off-by: Lukasz Dorau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants