Fix IPC benchmark in ubench #1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lplewa could you please add the IPC benchmark results to our ‘benchmark summary’ page? As far as I can see, there are currently no IPC results there. Please note that IPC performance is crucial for UMF, as we have customers who care about IPC performance |
bratpiorka
approved these changes
Feb 4, 2025
This is legacy benchmark - workflow use new benchmark which do not have benchmarks for IPC yet |
ok I will make sure that they will be added |
ldorau
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found that IPC benchmark in ubench is always disabled because of the issue with compiler macros.
Checklist