Add test for make install target #108
Conversation
ldorau
force-pushed
the
Add_test_for_make_install_target
branch
from
3866f4d to
7ba518d
Compare
test/test_make_install.sh
Outdated
|
|
||
| mkdir ${INSTALL_DIR} | ||
| cd ${BUILD_DIR} | ||
| make install |
There was a problem hiding this comment.
shouldn't we set DESTDIR here?
There was a problem hiding this comment.
No, it is already set in CMake in the line: -DCMAKE_INSTALL_PREFIX="${{env.INSTL_DIR}}"
There was a problem hiding this comment.
hm but what if someone runs this test outside the CI? I think this test should also work in this case or at least we should check if this cmake variable was set before and print an error otherwise.
There was a problem hiding this comment.
OK, we should use make install prefix=${INSTALL_DIR} here, because DESTDIR creates whole directory structure starting from root / inside this subdirectory.
So added make install prefix=${INSTALL_DIR}
Done.
|
It would be nice to have a simple program/example that we can compile and link against the installed version of UMF (it could be a simple CMake project) |
OK, I will do that in a separate PR. |
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_test_for_make_install_target
branch
from
7ba518d to
801b2f5
Compare
No description provided.