Add asserts for C tests #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
reviewed
Jan 8, 2024
test/common/test_helpers.h
Outdated
| #include <umf/base.h> | ||
| #include <umf/memory_pool.h> | ||
| #include <umf/memory_provider_ops.h> | ||
|
|
||
| #ifdef __cplusplus | ||
| #include <stdexcept> | ||
| static inline void UT_FATAL(const char *format, ...) { |
There was a problem hiding this comment.
You can just use the C-version of the UT_FATAL (the one under #else) since this is only expected to be used by C code anyway.
There was a problem hiding this comment.
@DamianDuy You are adding asserts for C tests, so you should add only the C version of UT_FATAL, not C++
igchor
approved these changes
Jan 9, 2024
bratpiorka
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds asserts for C tests (using the implementation from pmemstream: https://github.com/pmem/pmemstream/blob/master/tests/common/unittest.h) and uses them in a c test for disjoint pool.