Skip to content

Suppress CMake rerun to prevent custombuild timestamp error #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

Suppress CMake rerun to prevent custombuild timestamp error #1093

merged 1 commit into from
Feb 18, 2025

Conversation

luszczewskakasia1
Copy link
Contributor

Description

This avoid writing to the same generate.stamp while building UMF on Windows for L0 during nightly.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@luszczewskakasia1 luszczewskakasia1 requested a review from a team as a code owner February 11, 2025 14:57
@luszczewskakasia1 luszczewskakasia1 marked this pull request as draft February 12, 2025 06:40
@luszczewskakasia1 luszczewskakasia1 marked this pull request as ready for review February 13, 2025 10:04
lukaszstolarczuk
lukaszstolarczuk requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update commit message and the title of the PR

@luszczewskakasia1 luszczewskakasia1 changed the title Create separate directories for genetare.stamp Suppress CMake rerun to prevent custombuild generate.stamp error Feb 13, 2025
@luszczewskakasia1 luszczewskakasia1 changed the title Suppress CMake rerun to prevent custombuild generate.stamp error Suppress CMake rerun to prevent custombuild timestamp error Feb 13, 2025
@bratpiorka
Copy link
Contributor

IMO this would not work. This is a potential solution to the problem of rebuilding a project rather than building using concurrency.

@lukaszstolarczuk
Copy link
Contributor

@bratpiorka , @luszczewskakasia1 - did you manage to verify if that cmake command's param - "check stamp" (or something) is present now?

@luszczewskakasia1
Copy link
Contributor Author

@lukaszstolarczuk --check-stamp-file isn't present in .vcxproj files for each test. I haven't seen any other errors in other files.

@luszczewskakasia1 luszczewskakasia1 force-pushed the test-cmake branch 3 times, most recently from 1a89f85 to a4ee800 Compare February 14, 2025 16:24
lukaszstolarczuk
lukaszstolarczuk reviewed Feb 14, 2025
View reviewed changes
@luszczewskakasia1 luszczewskakasia1 marked this pull request as draft February 17, 2025 07:03
lukaszstolarczuk
lukaszstolarczuk approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this suppose to be still a draft? it looks like a final solution..

@luszczewskakasia1 luszczewskakasia1 marked this pull request as ready for review February 17, 2025 10:21
@luszczewskakasia1
Copy link
Contributor Author

@lukaszstolarczuk yes, right now it is the final solution

bratpiorka
bratpiorka reviewed Feb 18, 2025
View reviewed changes
@luszczewskakasia1 luszczewskakasia1 force-pushed the test-cmake branch 2 times, most recently from fbb09f7 to f301b3d Compare February 18, 2025 09:32
lukaszstolarczuk
lukaszstolarczuk requested changes Feb 18, 2025
View reviewed changes
@ghrunner
suppress CMake rerun
e45c4f9 
This avoids writing to the same generate.stamp while building UMF by not
rerunning CMakeLists.txt
@KFilipek KFilipek merged commit 2671373 into oneapi-src:main Feb 18, 2025
76 checks passed
@luszczewskakasia1 luszczewskakasia1 deleted the test-cmake branch May 29, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@KFilipek KFilipek KFilipek approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luszczewskakasia1 @bratpiorka @lukaszstolarczuk @KFilipek @ghrunner