Check if tracker is empty instead of clearing it #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bratpiorka @vinser52 please review |
ldorau
force-pushed
the
Check_if_tracker_is_empty_instead_of_clearing_it
branch
from
53fb9e7 to
791d018
Compare
vinser52
approved these changes
Feb 18, 2025
bratpiorka
reviewed
Feb 18, 2025
ldorau
force-pushed
the
Check_if_tracker_is_empty_instead_of_clearing_it
branch
from
dd363ed to
30d135c
Compare
Clearing the tracker was a temporary solution and should be removed. The tracker should be cleared using the provider's free() operation. Replace clear_tracker_for_the_pool() with check_if_tracker_is_empty(). This patch reverts commit 2766a21 Ref: oneapi-src#759 Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Check_if_tracker_is_empty_instead_of_clearing_it
branch
from
30d135c to
997c917
Compare
KFilipek
approved these changes
Feb 18, 2025
|
Hanging on the Windows CUDA build :-) ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clearing the tracker was a temporary solution and should be removed.
The tracker should be cleared using the provider's free() operation.
Replace
clear_tracker_for_the_pool()withcheck_if_tracker_is_empty().This patch reverts commit 2766a21
Ref: #759
Checklist