Add UMF_BUILD_OS_MEMORY_PROVIDER option to disable OS memory provider #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Add_UMF_BUILD_OS_MEMORY_PROVIDER_option
branch
from
9c4c5c7 to
47fecb0
Compare
PatKamin
approved these changes
Jan 9, 2024
bratpiorka
reviewed
Jan 9, 2024
test/CMakeLists.txt
Outdated
| LIBS jemalloc_pool) | ||
| endif() | ||
| else() | ||
| message(STATUS "The jemalloc_pool test is DISABLED, because UMF_BUILD_OS_MEMORY_PROVIDER is set to OFF") |
There was a problem hiding this comment.
jemalloc could use any memory provider to work - I would change this message to "The jemalloc_pool test is DISABLED, because it uses OS_MEMORY_PROVIDER, while UMF_BUILD_OS_MEMORY_PROVIDER flag is set to OFF" or similar
vinser52
approved these changes
Jan 9, 2024
vinser52
reviewed
Jan 9, 2024
| build_type: Release | ||
| compiler: {c: gcc, cxx: g++} | ||
| shared_library: 'ON' | ||
| os_provider: 'OFF' |
There was a problem hiding this comment.
what is the practical reason to test without the OS memory provider?
There was a problem hiding this comment.
Just to test if the UMF_BUILD_OS_MEMORY_PROVIDER option works correctly.
There was a problem hiding this comment.
@vinser52 UR or oneCCL does not require an OS provider. oneCCL does not even have libnuma or hwloc installed on its CI systems.
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_UMF_BUILD_OS_MEMORY_PROVIDER_option
branch
from
47fecb0 to
dc48e27
Compare
bratpiorka
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.