Cleanup atomics and fix deadlock in DP bucket_can_pool() #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_fix_dp_atomic
branch
5 times, most recently
from
c570a42 to
7bd9fd3
Compare
|
@bratpiorka we have the following issue in the backlog: #886. |
bratpiorka
force-pushed
the
rrudnick_fix_dp_atomic
branch
24 times, most recently
from
6861168 to
b294cc6
Compare
bratpiorka
force-pushed
the
rrudnick_fix_dp_atomic
branch
from
436aac8 to
7cba692
Compare
lplewa
reviewed
Feb 28, 2025
lplewa
requested changes
Feb 28, 2025
bratpiorka
force-pushed
the
rrudnick_fix_dp_atomic
branch
2 times, most recently
from
ca4a8f1 to
b41f1dd
Compare
igchor
approved these changes
Feb 28, 2025
bratpiorka
force-pushed
the
rrudnick_fix_dp_atomic
branch
8 times, most recently
from
7127d89 to
092bad7
Compare
vinser52
reviewed
Mar 3, 2025
vinser52
reviewed
Mar 3, 2025
src/utils/utils_concurrency.h
Outdated
| ASSERT_IS_ALIGNED((uintptr_t)ptr, 8); | ||
| ASSERT_IS_ALIGNED((uintptr_t)out, 8); | ||
| __atomic_load(ptr, out, memory_order_acquire); | ||
| //utils_annotate_acquire(ptr); |
vinser52
reviewed
Mar 3, 2025
bratpiorka
force-pushed
the
rrudnick_fix_dp_atomic
branch
4 times, most recently
from
d71076a to
0291b0c
Compare
igchor
approved these changes
Mar 4, 2025
|
@lplewa please re-review |
bratpiorka
force-pushed
the
rrudnick_fix_dp_atomic
branch
from
0291b0c to
0f540bc
Compare
bratpiorka
force-pushed
the
rrudnick_fix_dp_atomic
branch
from
0f540bc to
eae8d63
Compare
|
continue in #1151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup atomics and replace while(true) loop in Disjoint Pool bucket_can_pool() with a pair of atomic add/sub.
fix for #1125 and #1115
This PR is required by #1143