Skip to content

Fix Windows Unix Makefiles generator builds #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

PatKamin
Copy link
Contributor

@PatKamin PatKamin commented Feb 24, 2025

Using Unix Makefiles CMake generator on Windows with hwloc statically linked results in a build error. Now fetched hwloc is explicitly built before hwloc.lib is linked with other UMF targets.

// tested on sycl + extended testing

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

Using Unix Makefiles CMake generator on Windows results in a build error. Now fetched hwloc is explicitly built before the library is linked with other UMF targets.
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review February 25, 2025 15:36
@lukaszstolarczuk lukaszstolarczuk requested a review from a team as a code owner February 25, 2025 15:36
@lukaszstolarczuk lukaszstolarczuk merged commit 6b2e8f6 into oneapi-src:main Feb 25, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants