Skip to content

Use LOG_FATAL() in case of critical errors #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Feb 26, 2025

Description

Use LOG_FATAL() in case of critical errors.

Ref: #1095

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau requested a review from a team as a code owner February 26, 2025 09:50
Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there should be no value left instead of no left value, but never mind.
I've restarted workflows due to a connection issue. LGTM.

@ldorau
Copy link
Contributor Author

ldorau commented Feb 26, 2025

I think that there should be no value left instead of no left value, but never mind.

No, it should be no the left one value - this is the right meaning :-)))

@lukaszstolarczuk lukaszstolarczuk merged commit 113f3e0 into oneapi-src:main Feb 26, 2025
87 checks passed
@ldorau ldorau deleted the Use_LOG_FATAL_in_case_of_critical_errors branch February 27, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants