Fix return values from jemalloc hooks #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For OS provider, merge, split and commits are nops. This means we should return false, not true from those hooks. Ref: https://github.com/memkind/memkind/blob/c425635feb0367c43da8fa0deadb50a4bc127988/src/memkind_arena.c
igchor
force-pushed
the
fix_hooks_jemalloc
branch
from
cc61364 to
459a492
Compare
|
Eventually, we'll need to implement split, merge, and commit as functions in the provider. I've added TODOs for now. |
bratpiorka
approved these changes
Jan 10, 2024
|
FYI: I added a JIRA task related to added TODO |
ldorau
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OS provider, merge, split and commits are nops. This means we should return false, not true from
those hooks.
Ref: https://github.com/memkind/memkind/blob/c425635feb0367c43da8fa0deadb50a4bc127988/src/memkind_arena.c
@kswiecicki this should fix the ASAN issue.