Fix segfault in cu_memory_provider_get_last_native_error()
#1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bratpiorka @lukaszstolarczuk it is required for the CUDA fix: intel/llvm#17411 |
PatKamin
approved these changes
Mar 12, 2025
lplewa
reviewed
Mar 12, 2025
| strncpy(TLS_last_native_error.msg_buff, error_name, | ||
| TLS_MSG_BUF_LEN - 1); | ||
| } else { | ||
| strncpy(TLS_last_native_error.msg_buff, "cuGetErrorName() failed", |
There was a problem hiding this comment.
nit: can we extend this error message, or/and add comment, that it can happen if cuda is allready destroyed.
documentation for this functions, says that they never return NULL, so this might be misleading
There was a problem hiding this comment.
If the error code is not recognized, CUDA_ERROR_INVALID_VALUE will be returned and *pStr will be set to the NULL address.
ldorau
force-pushed
the
Fix_segfault_in_cu_memory_provider_get_last_native_error
branch
from
6596da2 to
19aba45
Compare
Fix segfault in cu_memory_provider_get_last_native_error() when it is called after a CUDA device was destroyed. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Fix_segfault_in_cu_memory_provider_get_last_native_error
branch
from
19aba45 to
7173cc5
Compare
bratpiorka
approved these changes
Mar 13, 2025
KFilipek
approved these changes
Mar 13, 2025
ldorau
deleted the
Fix_segfault_in_cu_memory_provider_get_last_native_error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix segfault in
cu_memory_provider_get_last_native_error()when it is called after a CUDA device was destroyed.Checklist