Do not call srand before each rand #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should only be called once, to initialize the seed. Otherwise, all values returned by rand() will be the same.
igchor
force-pushed
the
fix_compliance
branch
from
6f68012 to
6ecc931
Compare
|
@igchor But do you want this to be checked and merged? |
After we fix the issues with tests, yes. |
|
I belive this can be merged now, as #140 is merged |
bratpiorka
approved these changes
Jan 23, 2024
|
@igchor I have approved these changes, but could you change the description of this PR and write why we actually need them? |
lukaszstolarczuk
approved these changes
Jan 23, 2024
@bratpiorka, the commit message is alright. I copied its content to the PR description. I believe you can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should only be called once, to initialize the seed.
Otherwise, all values returned by rand() will be the same.