Skip to content

Add test for multiple NUMA nodes #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

DamianDuy
Copy link

No description provided.

@DamianDuy DamianDuy force-pushed the addMultipleNUMAnodesTest branch 2 times, most recently from 564194c to 6d091f8 Compare January 15, 2024 11:29
@DamianDuy DamianDuy force-pushed the addMultipleNUMAnodesTest branch 2 times, most recently from 14707ac to ac1e76b Compare January 22, 2024 13:27
@bratpiorka bratpiorka requested review from igchor and ldorau January 22, 2024 14:20
Copy link
Contributor

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test still fails on 2 nodes machine:

$ ./test/umf_test-provider_os_memory_multiple_NUMA_nodes
Running main() from /home/ldorau/work/unified-memory-framework/build/_deps/googletest-src/googletest/src/gtest_main.cc
[==========] Running 5 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 5 tests from testNUMAnodesAllocations/testNUMAnodes
[ RUN      ] testNUMAnodesAllocations/testNUMAnodes.checkNUMAnodesAllocations/0
[       OK ] testNUMAnodesAllocations/testNUMAnodes.checkNUMAnodesAllocations/0 (0 ms)
[ RUN      ] testNUMAnodesAllocations/testNUMAnodes.checkNUMAnodesAllocations/1
[       OK ] testNUMAnodesAllocations/testNUMAnodes.checkNUMAnodesAllocations/1 (0 ms)
[ RUN      ] testNUMAnodesAllocations/testNUMAnodes.checkNUMAnodesAllocations/2
alloc(1024) = 0x7fbc4dc45000, assigned NUMA node = 1
/home/ldorau/work/unified-memory-framework/test/provider_os_memory_multiple_NUMA_nodes.cpp:94: Failure
Expected equality of these values:
  numa_node
    Which is: 1
  i
    Which is: 0
[  FAILED  ] testNUMAnodesAllocations/testNUMAnodes.checkNUMAnodesAllocations/2, where GetParam() = (0, 1) (0 ms)
[ RUN      ] testNUMAnodesAllocations/testNUMAnodes.checkNUMAnodesAllocations/3
binding memory to NUMA node failed: Invalid argument
/home/ldorau/work/unified-memory-framework/test/provider_os_memory_multiple_NUMA_nodes.cpp:89: Failure
Expected equality of these values:
  umf_result
    Which is: 2
  UMF_RESULT_SUCCESS
    Which is: 0
[  FAILED  ] testNUMAnodesAllocations/testNUMAnodes.checkNUMAnodesAllocations/3, where GetParam() = (1, 1) (0 ms)
[ RUN      ] testNUMAnodesAllocations/testNUMAnodes.checkNUMAnodesAllocations/4
[       OK ] testNUMAnodesAllocations/testNUMAnodes.checkNUMAnodesAllocations/4 (0 ms)
[----------] 5 tests from testNUMAnodesAllocations/testNUMAnodes (0 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 1 test suite ran. (0 ms total)
[  PASSED  ] 3 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] testNUMAnodesAllocations/testNUMAnodes.checkNUMAnodesAllocations/2, where GetParam() = (0, 1)
[  FAILED  ] testNUMAnodesAllocations/testNUMAnodes.checkNUMAnodesAllocations/3, where GetParam() = (1, 1)

 2 FAILED TESTS

@bratpiorka bratpiorka self-requested a review January 29, 2024 08:52
@DamianDuy DamianDuy force-pushed the addMultipleNUMAnodesTest branch 4 times, most recently from bbb6a25 to f072150 Compare January 30, 2024 11:44
@DamianDuy DamianDuy marked this pull request as ready for review January 30, 2024 12:04
@DamianDuy DamianDuy requested a review from a team as a code owner January 30, 2024 12:04
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you execute this test on a multi-NUMA nodes environment?

struct testNumaNodes : public testing::TestWithParam<int> {
void SetUp() override {
if (numa_available() == -1 || numa_num_task_nodes() <= 1) {
GTEST_SKIP();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add some message to it << "message";

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done and yes, this test was developed and executed on a multi-NUMA nodes environment.

@DamianDuy DamianDuy force-pushed the addMultipleNUMAnodesTest branch from f072150 to c759919 Compare February 1, 2024 10:38
@ldorau
Copy link
Contributor

ldorau commented Feb 1, 2024

The test still fails on 2 nodes machine:

It works now

@bratpiorka bratpiorka merged commit b1068dc into oneapi-src:main Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants