Skip to content

require specific versions of sphinxcontrib to gen docs #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2024
Merged

require specific versions of sphinxcontrib to gen docs #145

merged 1 commit into from
Jan 16, 2024

Conversation

bratpiorka
Copy link
Contributor

@bratpiorka bratpiorka commented Jan 15, 2024 •
edited
Loading

this PR fixes building HTML docs

@bratpiorka bratpiorka force-pushed the rrudnick_sphinks_5 branch 3 times, most recently from ff81769 to 7c29e3c Compare January 15, 2024 12:16
@bratpiorka bratpiorka marked this pull request as ready for review January 15, 2024 12:31
@bratpiorka bratpiorka requested a review from a team as a code owner January 15, 2024 12:31
@PatKamin
Copy link
Contributor

Please, provide a link to the html docs preview.

lukaszstolarczuk
lukaszstolarczuk reviewed Jan 15, 2024
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why did it stop working exactly...? It looks like it was out of the blue, after Igor's change...

My concern is, that bumping Sphinx version may lead to stop working for other OSes (like Rocky Linux or OpenSUSE - that was my experience with dockers on UR). I'm not sure how much you care about it 😉

lukaszstolarczuk
lukaszstolarczuk reviewed Jan 15, 2024
View reviewed changes
@bratpiorka bratpiorka changed the title bump sphinx ver to 5.0 require specific versions of sphinxcontrib to gen docs Jan 15, 2024
@bratpiorka
Copy link
Contributor Author

Please, provide a link to the html docs preview.

@PatKamin when I require specific versions of sphinx contrib I fix the building while the layout doesn't change, see: https://bratpiorka.github.io/unified-memory-framework/api.html#memory-provider

@bratpiorka
Copy link
Contributor Author

Do you know why did it stop working exactly...? It looks like it was out of the blue, after Igor's change...

My concern is, that bumping Sphinx version may lead to stop working for other OSes (like Rocky Linux or OpenSUSE - that was my experience with dockers on UR). I'm not sure how much you care about it 😉
.
@lukaszstolarczuk I'm not sure... the only thing I saw is the different version of github image provisioner. Maybe Python requirements were searched and installed in a different order? Anyway, I kept the current version of Sphinx

@bratpiorka bratpiorka merged commit 0c60544 into oneapi-src:main Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldorau ldorau ldorau approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

@PatKamin PatKamin PatKamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bratpiorka @PatKamin @ldorau @lukaszstolarczuk