Skip to content

Tracking provider cannot change behavior of upstream provider #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Jan 15, 2024

Tracking provider cannot change behavior of the upstream provider. Tracking provider should be transparent for the upstream provider.

@ldorau ldorau requested a review from a team as a code owner January 15, 2024 12:56
@bratpiorka bratpiorka requested a review from igchor January 15, 2024 15:36
@vinser52
Copy link
Contributor

Could you please also fix the trackingAlloc function and align it with this PR. This part looks strange:

ret = umfMemoryTrackerAdd(p->hTracker, p->pool, *ptr, size);
    if (ret != UMF_RESULT_SUCCESS && p->hUpstream) {
        if (umfMemoryProviderFree(p->hUpstream, *ptr, size)) {
            // TODO: LOG
        }
    }

if we are not able to add new block to the tracker we should not call umfMemoryProviderFree, right?

@ldorau ldorau force-pushed the Tracking_provider_cannot_change_behavior_of_upstream_provider branch from da4a238 to e225178 Compare January 16, 2024 08:03
@ldorau
Copy link
Contributor Author

ldorau commented Jan 16, 2024

Could you please also fix the trackingAlloc function and align it with this PR. This part looks strange:
if we are not able to add new block to the tracker we should not call umfMemoryProviderFree, right?

Right. Done.

Tracking provider cannot change behavior of the upstream provider.
Tracking provider should be transparent for the upstream provider.

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Tracking_provider_cannot_change_behavior_of_upstream_provider branch from e225178 to 6f3c663 Compare January 16, 2024 12:13
@bratpiorka bratpiorka merged commit e23fbd4 into oneapi-src:main Jan 17, 2024
@ldorau ldorau deleted the Tracking_provider_cannot_change_behavior_of_upstream_provider branch January 17, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants