-
Notifications
You must be signed in to change notification settings - Fork 35
Use base allocator in critnib #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
302d21f
to
7a8b3c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
others - please review as I'm on vacation
e9106a5
to
4af17cc
Compare
Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
4af17cc
to
5714aea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally okay, but if the function umf_ba_linear_destroy
needs an explanation every time that it also destroys the parent (the provider), it should have another name. If it's not the topic for this PR, please do it separately, I would be grateful.
void umf_ba_linear_destroy(umf_ba_linear_pool_t *pool) {
util_mutex_destroy_not_free(&pool->metadata.lock);
ba_os_free(pool, pool->metadata.pool_size);
} |
Currently, I'm not sure what I've seen previously, but you're right about your changes. Sorry for that. |
@igchor Can we merge this PR? |
Requires: