Use base allocator in memory pool, provider, target and memspace #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Use_base_allocator_in_memory_pool_provider_and_target
branch
from
cf2bf0c to
a1670bd
Compare
KFilipek
reviewed
Jan 29, 2024
ldorau
force-pushed
the
Use_base_allocator_in_memory_pool_provider_and_target
branch
from
a1670bd to
31f3db7
Compare
ldorau
changed the title
igchor
requested changes
Jan 29, 2024
KFilipek
approved these changes
Jan 30, 2024
ldorau
force-pushed
the
Use_base_allocator_in_memory_pool_provider_and_target
branch
5 times, most recently
from
9d07d72 to
f53288e
Compare
|
I will squash the commits when it is approved. |
igchor
reviewed
Feb 1, 2024
bratpiorka
requested changes
Feb 2, 2024
src/memory_pool_default.c
Outdated
|
|
||
| assert(sizeof(umf_memory_pool_t) < SIZE_BA_POOL_CHUNK); | ||
|
|
||
| umf_memory_pool_handle_t pool = umf_ba_alloc(BA_pool); |
There was a problem hiding this comment.
How many base allocators will we have after merging this PR? Single? If so we could change this function to accept zero arguments and make it use BA_pool internally.
|
@ldorau @bratpiorka please see: #203 With those changes we can just use umf__ba_alloc(size) whenever needed and there is no need to create additional pools manually. |
ldorau
force-pushed
the
Use_base_allocator_in_memory_pool_provider_and_target
branch
3 times, most recently
from
e81f370 to
ac9591b
Compare
bratpiorka
requested changes
Feb 5, 2024
| // saved pointer to the global base allocator | ||
| umf_ba_pool_t *base_allocator; | ||
|
|
||
| // saved pointer to the memspace linear base allocator |
There was a problem hiding this comment.
I think you could write here "TODO this is a private copy of linear allocator - optimize this"
ldorau
force-pushed
the
Use_base_allocator_in_memory_pool_provider_and_target
branch
from
ac9591b to
c85b936
Compare
bratpiorka
approved these changes
Feb 5, 2024
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Use_base_allocator_in_memory_pool_provider_and_target
branch
from
c85b936 to
7beb87a
Compare
|
@igchor review again, please |
igchor
approved these changes
Feb 5, 2024
ldorau
deleted the
Use_base_allocator_in_memory_pool_provider_and_target
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.