Cleanup OS provider config API #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are only applicable for already allocated memory. Right now, UMF provider does not expose any API for calling mbind after allocation or moving specific pages.
bratpiorka
approved these changes
Feb 6, 2024
ldorau
approved these changes
Feb 6, 2024
There was only one possible value (UMF_NUMA_FLAG_STRICT) but it seems to mostly apply to page migration (i.e. when MPOL_MF_MOVE is specified). Since UMF does not support this for now, there's no point in keeping this flag. During allocation time, we still have UMF_NUMA_MODE_PREFFERED that can be used to request a 'preffered' binding. For any other mode, we require mbind to succeed.
There is no relative node id concept on Windows. Moreover, the provider API should be as simple as possible. If we'd like to add support for relative nodes in the future, we can always expose a function to translate node ids.
pbalcer
approved these changes
Feb 12, 2024
vinser52
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vinser52 @pbalcer please review. Each commit is an independent change.