Skip to content

Use base allocator in the OS provider #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Feb 6, 2024

No description provided.

@ldorau ldorau requested a review from a team as a code owner February 6, 2024 10:19
@ldorau
Copy link
Contributor Author

ldorau commented Feb 6, 2024

What about:

            hwloc_bitmap_list_asprintf(&strp, nodeset);
            free(strp);

?

@ldorau
Copy link
Contributor Author

ldorau commented Feb 6, 2024

Fixes of error handling submitted in #211

@bratpiorka
Copy link
Contributor

            hwloc_bitmap_list_asprintf(&strp, nodeset);
            free(strp);

hwloc uses malloc:
https://github.com/open-mpi/hwloc/blob/eeeda4ad2d0511a2334a02141dab6138b1e0ce47/hwloc/bitmap.c#L480C9-L480C15

@igchor maybe we should use hwloc only for topo discovery which is not needed in OS provider?

@ldorau
Copy link
Contributor Author

ldorau commented Feb 6, 2024

hwloc_topology_init() can also use malloc():
https://github.com/open-mpi/hwloc/blob/master/hwloc/topology.c#L3853

@ldorau
Copy link
Contributor Author

ldorau commented Feb 6, 2024

            hwloc_bitmap_list_asprintf(&strp, nodeset);
            free(strp);

hwloc uses malloc: https://github.com/open-mpi/hwloc/blob/eeeda4ad2d0511a2334a02141dab6138b1e0ce47/hwloc/bitmap.c#L480C9-L480C15

@igchor maybe we should use hwloc only for topo discovery which is not needed in OS provider?

@bratpiorka @igchor I think it is a separate issue for a separate PR and this PR can be merged without fixing this issue.

@bratpiorka
Copy link
Contributor

            hwloc_bitmap_list_asprintf(&strp, nodeset);
            free(strp);

hwloc uses malloc: https://github.com/open-mpi/hwloc/blob/eeeda4ad2d0511a2334a02141dab6138b1e0ce47/hwloc/bitmap.c#L480C9-L480C15
@igchor maybe we should use hwloc only for topo discovery which is not needed in OS provider?

@bratpiorka @igchor I think it is a separate issue for a separate PR and this PR can be merged without fixing this issue.

agree

@ldorau ldorau merged commit eacd4d1 into oneapi-src:main Feb 6, 2024
@ldorau ldorau deleted the Use_base_allocator_in_the_OS_provider branch February 6, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants