Skip to content

Basic example with documentation #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

PatKamin
Copy link
Contributor

@PatKamin PatKamin commented Feb 7, 2024

Add an example with allocating memory with the usage of OS Memory Provider
and Scalable Pool.

preview of docs

TODO:

  • install example
  • run example in CI
  • add links where possible

@PatKamin PatKamin force-pushed the basic-example branch 3 times, most recently from a6056bb to 66d0504 Compare February 7, 2024 14:56
@igchor
Copy link
Member

igchor commented Feb 7, 2024

Looks great! Are you going to do all those 'todos' in this PR?

@PatKamin
Copy link
Contributor Author

PatKamin commented Feb 8, 2024

Looks great! Are you going to do all those 'todos' in this PR?

Yes, all TODOs from the PR description will be done as part of this PR.

@PatKamin PatKamin force-pushed the basic-example branch 3 times, most recently from 9bdd9cd to 21c4d8e Compare February 8, 2024 14:48
@PatKamin PatKamin requested a review from bratpiorka February 8, 2024 14:49
@PatKamin PatKamin force-pushed the basic-example branch 4 times, most recently from 76d078d to a3ba79b Compare February 9, 2024 14:25
@PatKamin
Copy link
Contributor Author

The main work on this PR is done. The PR will be undrafted when all current and possible future review conversations will be resolved.

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PatKamin PatKamin force-pushed the basic-example branch 2 times, most recently from e8c0a3c to f366181 Compare February 14, 2024 11:50
@PatKamin PatKamin marked this pull request as ready for review February 14, 2024 11:50
@PatKamin PatKamin requested a review from a team as a code owner February 14, 2024 11:50
@igchor
Copy link
Member

igchor commented Feb 14, 2024

@PatKamin please rebase

Add an example with allocating memory with the usage of OS memory provider
and Scalable pool.
@PatKamin
Copy link
Contributor Author

@PatKamin please rebase

Done

@bratpiorka bratpiorka merged commit 7043b59 into oneapi-src:main Feb 15, 2024
@PatKamin PatKamin deleted the basic-example branch December 31, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants